fix: replace innerHTML with DOM node construction to prevent XSS (Closes #7137) [FaaFyfxR9WAQrL7FcAgEHJvztd8cVMxvjHRS55rw1nwH]#8037
Open
waterWang wants to merge 1 commit into
Conversation
Contributor
|
Welcome to RustChain! Thanks for your first pull request. Before we review, please make sure:
Bounty tiers: Micro (1-10 RTC) | Standard (20-50) | Major (75-100) | Critical (100-150) A maintainer will review your PR soon. Thanks for contributing! |
github-actions
Bot
added
BCOS-L1
Author
|
Hi @Scottcjn, this PR fixes XSS vulnerabilities by replacing innerHTML with safe DOM node construction. Would appreciate a review when you have a moment. Thanks! |
waterWang
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Security Fix
Replaces all
innerHTMLusages intools/bcos-badge-generator/index.htmlwith safe DOM node construction (createElement,textContent,appendChild,replaceChildren).Changes
previewArea.innerHTML = ''→previewArea.replaceChildren()generateBtn.innerHTML = '<span class="spinner"></span>Generating...'→createElement('span')+createTextNodecreateElementandtextContentinstead of template stringsThis prevents XSS injection through the preview fallback content path.
Closes #7137